On Fri, 22 Sep 2023 14:52:06 -0500 Rob Herring <robh@xxxxxxxxxx> wrote: > On Thu, Sep 21, 2023 at 11:32 AM Hugo Villeneuve <hugo@xxxxxxxxxxx> wrote: > > > > On Thu, 21 Sep 2023 11:24:24 -0500 > > Rob Herring <robh@xxxxxxxxxx> wrote: > > > > > On Wed, Sep 20, 2023 at 11:20:14AM -0400, Hugo Villeneuve wrote: > > > > From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx> > > > > > > > > The NXP-specific "irda-mode-ports" property lacks a proper vendor > > > > prefix. Add "nxp," prefix to comply with DT best practises. > > > > > > The opposite direction would be worth carrying in the driver, but I > > > don't think adding a vendor prefix is. I would just leave this as-is. > > > > > > Rob > > > > Hi Rob, > > I am not following you, can you clarify? > > Just keep the property as-is and don't add a 'nxp,' prefixed version. > It's not worth carrying the fallback in the driver. > > If you were dropping a vendor prefix from a property, then that's > worth it because there might be other users added. > > Rob Hi Rob, ok, then I will drop this patch as well as the other titled 'serial: sc16is7xx: recognize "nxp,irda-mode-ports" DT property' for V2. Hugo.
