On Tue, Sep 26, 2023 at 10:26 AM Conor Dooley <conor@xxxxxxxxxx> wrote: > > + - items: > > + - const: linksys,wrv54g > > + - const: gemtek,gtwx5715 > > + - const: intel,ixp42x > > One question, not so much about this particular case, but is there no > "standalone" version of the gtwx5715 sold by gemtek? Asking as I don't > see it in the enum above. The description sounds like it is both a > product in its own right & sold rebadged. Yeah this one is a special headache. It's two different brandings of the same router. The Linksys version can still be bought new from Amazon: https://www.amazon.com/Cisco-Linksys-WRV54G-Wireless-G-VPN-Router/dp/B0000AR8Z1 I'm leaning toward listing them as two different devices instead of what we have now, which is compatible = "linksys,wrv54g", "gemtek,gtwx5715", "intel,ixp42x"; We can just decide that one of them is the canon device, I guess Linksys, and the other we can just use that device tree, or we create a device tree that includes the former and just override the compatible. I don't really know what to do here. Yours, Linus Walleij
