On Mon, 2023-09-25 at 08:44 +0200, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On 25/09/2023 07:21, Jason-JH Lin (林睿祥) wrote: > > Hi Krzysztof, > > > > Thanks for the reviews. > > > > On Sat, 2023-09-23 at 20:03 +0200, Krzysztof Kozlowski wrote: > >> > >> External email : Please do not click links or open attachments > until > >> you have verified the sender or the content. > >> On 18/09/2023 21:21, Jason-JH.Lin wrote: > >>> CMDQ client can use a loop flag for the CMDQ packet to make > current > >>> command buffer jumps to the beginning when GCE executes to the > end > >>> of commands buffer. > >>> > >>> GCE irq occurs when GCE executes to the end of command > instruction. > >>> If the CMDQ packet is a loopping command, GCE irq handler can not > >>> delete the CMDQ task and disable the GCE thread. > >>> > >>> Add cmdq_mbox_stop to support thread disable > >> > >> How or where do you add it? I do not see it in this patch. Your > >> patchset > >> looks randomly organized. > > > > This will be used in cmdq_pkt_finialize_loop() at [PATCH 8/15]. > > > > mtk-cmdq-helper.c and mtk-cmdq-mailbox.c are not in the > > same maintainer's tree, so I separate this to another patch from > [PATCH > > 8/15]. > > Why? Anyway it has to go through same tree. You have dependencies. > Such > artificial split makes it only difficult to review and understand. > Re-organize your patchset to be correctly split per each logical > feature/change. Split per subsystems is not the same. > Yes, these related files are in the different maintainer's tree. Refer to https://www.kernel.org/doc/linux/MAINTAINERS MAILBOX API M: Jassi Brar F: drivers/mailbox/ - drivers/mailbox/mtk-cmdq-mailbox.c - drivers/mailbox/mtk-cmdq-sec- mailbox.c ARM/Mediatek SoC support M: Matthias Brugger F: drivers/soc/mediatek/ K: mediatek - drivers/soc/mediatek/mtk-cmdq-helper.c - include/linux/soc/mediatek/mtk-cmdq.h I think we should add a new MAINTAINER label for mediatek CMDQ mailbox and put these files together, such as "MAILBOX ARM MHUv2" and "QUALCOM IPCC MAILBOX DRIVER". But I don't know how to make a request for that. Anyway, I'll squash this logical feature to the same patch, no matter these files are not in the same tree. Regards, Jason-JH.Lin > Best regards, > Krzysztof >
