On 25/09/2023 07:21, Jason-JH Lin (林睿祥) wrote: > Hi Krzysztof, > > Thanks for the reviews. > > On Sat, 2023-09-23 at 20:03 +0200, Krzysztof Kozlowski wrote: >> >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> On 18/09/2023 21:21, Jason-JH.Lin wrote: >>> CMDQ client can use a loop flag for the CMDQ packet to make current >>> command buffer jumps to the beginning when GCE executes to the end >>> of commands buffer. >>> >>> GCE irq occurs when GCE executes to the end of command instruction. >>> If the CMDQ packet is a loopping command, GCE irq handler can not >>> delete the CMDQ task and disable the GCE thread. >>> >>> Add cmdq_mbox_stop to support thread disable >> >> How or where do you add it? I do not see it in this patch. Your >> patchset >> looks randomly organized. > > This will be used in cmdq_pkt_finialize_loop() at [PATCH 8/15]. > > mtk-cmdq-helper.c and mtk-cmdq-mailbox.c are not in the > same maintainer's tree, so I separate this to another patch from [PATCH > 8/15]. Why? Anyway it has to go through same tree. You have dependencies. Such artificial split makes it only difficult to review and understand. Re-organize your patchset to be correctly split per each logical feature/change. Split per subsystems is not the same. Best regards, Krzysztof
