On Mon, 25 Sep 2023 08:54:08 +0200 Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > On 25/09/2023 00:25, Andreas Kemnade wrote: > > Found in ancient platform data struct: > > level_shifter: 0: VLogic, 1: VDD > > > > Signed-off-by: Andreas Kemnade <andreas@xxxxxxxxxxxx> > > --- > > .../devicetree/bindings/iio/imu/invensense,mpu6050.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml > > index 1db6952ddca5e..6aae2272fa15c 100644 > > --- a/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml > > +++ b/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml > > @@ -48,6 +48,8 @@ properties: > > > > mount-matrix: true > > > > + invensense,level-shifter: true > > It does not look like you tested the bindings, at least after quick > look. Please run `make dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > Maybe you need to update your dtschema and yamllint. > > Best regards, > Krzysztof > > Also this one isn't obvious - give it a description in the binding doc. I'm not sure of the arguement for calling it level shift in general. Jonathan