On Tue, Sep 19, 2023 at 9:55 PM Lee Jones <lee@xxxxxxxxxx> wrote: > > On Tue, 19 Sep 2023, Chen-Yu Tsai wrote: > > > When support for the MT6366 PMIC regulators was added, it was assumed > > that it had the same functionality as MT6358. In reality there are > > differences. A few regulators have different ranges, or were renamed > > and repurposed, or removed altogether. > > > > Add the 3 regulators that were missing from the original submission. > > These are added for completeness. VSRAM_CORE is not used in existing > > projects. VM18 and VMDDR feed DRAM related consumers, and are not used > > in-kernel. > > > > Signed-off-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx> > > --- > > Changes since v2: > > - Linear range selector values fixed > > > > Angelo's reviewed-by was dropped. > > > > drivers/regulator/mt6358-regulator.c | 20 ++++++++++++++++++++ > > > include/linux/mfd/mt6358/registers.h | 17 +++++++++++++++++ > > Acked-by: Lee Jones <lee@xxxxxxxxxx> Thanks! Could you also take a look at another patch this series is based on and ack that one? It's "regulator: mt6358: Add output voltage fine tuning to fixed regulators", with message ID "20230913082919.1631287-3-wenst@xxxxxxxxxxxx" [1]. ChenYu [1] https://lore.kernel.org/linux-arm-kernel/20230913082919.1631287-4-wenst@xxxxxxxxxxxx/ > > > include/linux/regulator/mt6358-regulator.h | 3 +++ > > 3 files changed, 40 insertions(+) > > [...] > > -- > Lee Jones [李琼斯]
