On 9/16/23 15:41, Lukas Walter wrote:
This dts adds support for Huawei Honor 5X / GR5 (2016) smartphone
released in 2015.
Add device tree with initial support for:
- GPIO keys
- Hall sensor
- SDHCI (internal and external storage)
- WCNSS (BT/WIFI)
- Sensors (accelerometer, proximity and gyroscope)
- Vibrator
- Touchscreen
Signed-off-by: Lukas Walter <lukas.walter@xxxxxxxxx>
Signed-off-by: Raymond Hackley <raymondhackley@xxxxxxxxxxxxxx>
---
Beyond the signoff question from Krzysztof, this looks really good.
Some comments below.
[...]
+
+ reserved-memory {
+ reserved@84a00000 {
+ reg = <0x0 0x84a00000 0x0 0x1600000>;
+ no-map;
+ };
Do we know what this is for?
+ };
+
+ gpio-hall-sensor {
+ compatible = "gpio-keys";
+
+ pinctrl-0 = <&gpio_hall_sensor_default>;
+ pinctrl-names = "default";
+
+ label = "GPIO Hall Effect Sensor";
I think we can have both hall sensor and V+ under gpio-keys
And then I am not sure how useful the label is for the container
node, maybe you or somebody else can tell me whether it's used
anywhere
+
+ event-hall-sensor {
+ label = "Hall Effect Sensor";
+ gpios = <&tlmm 69 GPIO_ACTIVE_LOW>;
+ linux,input-type = <EV_SW>;
+ linux,code = <SW_LID>;
+ linux,can-disable;
Should this not be a wakeup-source btw?
+ };
+ };
+
[...]
+ /*
+ * NOTE: vdd is not directly supplied by pm8916_l16, it seems to be a
+ * fixed regulator that is automatically enabled by pm8916_l16.
That sounds reasonable, many boards have such circuits
Konrad
