On Wed, 20 Sep 2023 14:50:43 +0300, Tony Lindgren wrote: > Allow configuring an optional dedicated wakeirq for gpio-keys that > some SoCs have. > > Let's use the common interrupt naming "irq" and "wakeup" that we already > have in use for some drivers and subsystems like i2c framework. > > Note that the gpio-keys interrupt property is optional. If only a gpio > property is specified, the driver tries to translate the gpio into an > interrupt. > > Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx> > --- > > Changes since v1: > > - Run make dt_binding_check on the binding > > - Add better checks for interrupt-names as suggested by Rob, it is > now required if two interrupts are configured > > - Add more decription entries > > - Add a new example for key-wakeup > > --- > .../devicetree/bindings/input/gpio-keys.yaml | 41 ++++++++++++++++++- > 1 file changed, 40 insertions(+), 1 deletion(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/input/gpio-keys.yaml:36:13: [warning] wrong indentation: expected 14 but found 12 (indentation) ./Documentation/devicetree/bindings/input/gpio-keys.yaml:38:13: [warning] wrong indentation: expected 14 but found 12 (indentation) ./Documentation/devicetree/bindings/input/gpio-keys.yaml:47:13: [warning] wrong indentation: expected 14 but found 12 (indentation) ./Documentation/devicetree/bindings/input/gpio-keys.yaml:49:13: [warning] wrong indentation: expected 14 but found 12 (indentation) dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230920115044.53098-1-tony@xxxxxxxxxxx The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
