On Tue, Sep 19, 2023 at 11:13:13AM +0000, Parthiban.Veerasooran@xxxxxxxxxxxxx wrote:
> Hi Andrew,
>
> On 13/09/23 7:46 am, Andrew Lunn wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> >> +struct oa_tc6 {
> >> + struct spi_device *spi;
> >> + bool ctrl_prot;
> >> +};
> >
> > Should this be considered an opaque structure which the MAC driver
> > should not access the members?
Opaque vs not opaque is an important design decision. If the MAC
driver is allowed to directly access this structure, you should
document the locking concept. If the MAC is not supposed to access it
directly, only uses getters/setters, that also needs documenting, and
maybe even make it a void * in the MAC driver.
Andrew
