On Fri, 15 Sep 2023, Rob Herring wrote: > > On Fri, 15 Sep 2023 15:15:05 -0500, Rob Herring wrote: > > The Arm Ltd board bindings are a bit unusual in that they define child > > nodes for various syscon's. The schemas are also incomplete as they lack > > constraints on having additional properties and some properties are > > missing. As the bindings for the different platforms only vary by > > compatibles, combine them into a single schema doc. > > > > Add the "arm,im-pd1-syscon" compatible which was not documented. Add > > "ranges", "#address-cells", and "#size-cells properties which were > > missing. > > > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > > --- > > .../bindings/arm/arm,integrator.yaml | 39 ----------- > > .../devicetree/bindings/arm/arm,realview.yaml | 37 ---------- > > .../bindings/arm/arm,versatile.yaml | 40 +++-------- > > .../mfd/arm,dev-platforms-syscon.yaml | 67 +++++++++++++++++++ > > 4 files changed, 75 insertions(+), 108 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/mfd/arm,dev-platforms-syscon.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): Errr ... I'm a little torn. Do I trust the maintainer or his bot? :) > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/register-bit-led.example.dtb: syscon@10000000: compatible: 'oneOf' conditional failed, one must be fixed: > ['arm,realview-pb1176-syscon', 'syscon'] is too short > 'arm,realview-pb1176-syscon' is not one of ['arm,integrator-ap-syscon', 'arm,integrator-cp-syscon', 'arm,integrator-sp-syscon', 'arm,im-pd1-syscon'] > 'arm,realview-pb1176-syscon' is not one of ['arm,realview-eb11mp-revb-syscon', 'arm,realview-eb11mp-revc-syscon'] > 'arm,realview-eb-syscon' was expected > from schema $id: http://devicetree.org/schemas/mfd/arm,dev-platforms-syscon.yaml# > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230915201520.4179115-1-robh@xxxxxxxxxx > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > -- Lee Jones [李琼斯]
