Quoting Conor Dooley (2023-09-15 22:13:40) > Yo, > > On Fri, Sep 15, 2023 at 05:59:45PM +0100, Kieran Bingham wrote: > > Add YAML device tree bindings for the ROHM BU64754 VCM Motor Driver for > > Camera Autofocus. > > > > Signed-off-by: Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx> > > --- > > .../bindings/media/i2c/rohm,bu64754.yaml | 48 +++++++++++++++++++ > > MAINTAINERS | 7 +++ > > 2 files changed, 55 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/rohm,bu64754.yaml > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/rohm,bu64754.yaml b/Documentation/devicetree/bindings/media/i2c/rohm,bu64754.yaml > > new file mode 100644 > > index 000000000000..22da4a46bb0c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/i2c/rohm,bu64754.yaml > > @@ -0,0 +1,48 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +# Copyright (C) 2023 Ideas on Board Oy. > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/i2c/rohm,bu64754.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ROHM BU64754 Actuator Driver for Camera Autofocus > > + > > +maintainers: > > + - Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx> > > + > > +description: | > > That | is surplus to requirements since you have no formatting to > preserve. > > > + The BU64754 is an actuator driver IC which can control the actuator > > + position precisely using an internal Hall Sensor. > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - rohm,bu64754 > > Why such a complicated pattern when you only have one item here? > Why not just const: rohm,bu64754? These devices are really simple. I'd expect other versions/variants to be able to be covered by the same driver in the future, but I can remove this for now and simplify. > > Otherwise, looks fine to me. Thanks for the review. -- Kieran
