Hi Rob,
On Thu, Sep 14, 2023 at 09:59:35AM -0500, Rob Herring wrote:
> On Wed, Sep 13, 2023 at 04:28:11PM -0300, Fabio Estevam wrote:
> > From: Fabio Estevam <festevam@xxxxxxx>
> >
> > As explained in the description text from trivial-devices.yaml:
> >
> > "This is a list of trivial I2C and SPI devices that have simple device tree
> > bindings, consisting only of a compatible field, an address and possibly an
> > interrupt line."
> >
> > A camera device does not fall into this category as it needs other
> > properties such as regulators, reset and powerdown GPIOs, clocks,
> > media endpoint.
> >
> > Remove the OV5642 entry from trivial-devices.yaml and add its own
> > ovti,ov5642.yaml.
>
> Many of these Omnivision sensors have the same supplies and same GPIO
> connections, so why can't they share the binding? There are some
> differences I've seen that boil down to just what the driver decided to
> require or not, but that shouldn't really vary. See commit 44ade291b77c
> ("media: dt-bindings: Merge OV5695 into OV5693 binding") for example.
>
> In any case, the binding looks fine and any merging can be done after.
The sensors differ from interface capabilities (one or more of parallel,
CSI-2 D-PHY and CSI-2 C-PHY), number of lanes / data lines etc. For
historical reasons, many have different defaults for vsync and hsync
polarities, for instance.
I suppose some of these would reasonably be taken into account, if not in a
single file, in a couple of files. CSI-2 connected sensors are the most
common these days.
The device for which this patch added the bindings appears to be 15 years
old.
--
Regards,
Sakari Ailus
