Hi Krzysztof, > On 14/09/2023 12:20, Xu Yang wrote: > > Add DDR controller node which will be used by EDAC driver later, also > > move the DDR PMU node as the subnode of the DDR controller. > > > > Signed-off-by: Ye Li <ye.li@xxxxxxx> > > Signed-off-by: Xu Yang <xu.yang_2@xxxxxxx> > > --- > > arch/arm64/boot/dts/freescale/imx93.dtsi | 18 ++++++++++++++---- > > 1 file changed, 14 insertions(+), 4 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi > > index 6f85a05ee7e1..992bdeef70cd 100644 > > --- a/arch/arm64/boot/dts/freescale/imx93.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi > > @@ -917,10 +917,20 @@ media_blk_ctrl: system-controller@4ac10000 { > > status = "disabled"; > > }; > > > > - ddr-pmu@4e300dc0 { > > - compatible = "fsl,imx93-ddr-pmu"; > > - reg = <0x4e300dc0 0x200>; > > - interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>; > > + ddr: memory-controller@4e300000 { > > + compatible = "simple-mfd"; > > No, that's not allowed alone. Well, then how should I modify this compatible? > > It does not look like you tested the DTS against bindings. Please run > `make dtbs_check W=1` > I just run the check script, it seems no warnings for this node. $ dt-validate -s Documentation/devicetree/bindings/processed-schema.json arch/arm64/boot/dts/freescale/imx93-11x11-evk.dtb /home/nxf75279/work/linux-next/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dtb: tmu@44482000: fsl,tmu-range: 'oneOf' conditional failed, one must be fixed: [2147483866, 2147483881, 2147483906, 2147483946, 2147484006, 2147484071, 2147484086] is too long From schema: /home/nxf75279/work/linux-next/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml /home/nxf75279/work/linux-next/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dtb: tmu@44482000: 'oneOf' conditional failed, one must be fixed: 'interrupts' is a required property 'interrupts-extended' is a required property From schema: /home/nxf75279/work/linux-next/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml /home/nxf75279/work/linux-next/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dtb: gpio@43820080: gpio-ranges: [[30, 0, 84, 8], [30, 8, 66, 18], [30, 26, 34, 2], [30, 28, 0, 4]] is too long From schema: /home/nxf75279/work/linux-next/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml /home/nxf75279/work/linux-next/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dtb: gpio@43830080: gpio-ranges: [[30, 0, 38, 28], [30, 28, 36, 2]] is too long From schema: /home/nxf75279/work/linux-next/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml Thanks, Xu Yang