On 13/09/2023 10:28, Guo Mengqi wrote: > Add device-tree binding documentation for sdma hardware on > HiSilicon Ascend SoC families. > > Signed-off-by: Guo Mengqi <guomengqi3@xxxxxxxxxx> > --- > + dma-channel-mask: > + minItems: 1 > + maxItems: 2 Why 2? Care to bring any example? Where is your DTS? > + iommus: > + maxItems: 1 > + > + pasid-num-bits: > + description: | > + This tells smmu that this device supports iommu-sva feature. > + This determines the maximum number of digits in the pasid. > + maximum: 0x10 > + > + dma-coherent: true > + > + dma-can-stall: true > + > +required: > + - compatible > + - reg > + - dma-channel-mask > + - '#dma-cells' > + - iommus > + - pasid-num-bits > + - dma-can-stall I am not sure if requiring dma-can-stall is correct here. To my understanding this is in general optional property. Best regards, Krzysztof
