Hi Simon, Thank you for reviewing the patch. On 10/09/23 11:28 pm, Simon Horman wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Fri, Sep 08, 2023 at 07:59:17PM +0530, Parthiban Veerasooran wrote: >> The ethernet frame to be sent to MAC-PHY is converted into multiple >> transmit data chunks. A transmit data chunk consists of a 4-byte data >> header followed by the transmit data chunk payload. >> >> The received ethernet frame from the network is converted into multiple >> receive data chunks by the MAC-PHY and a receive data chunk consists of >> the receive data chunk payload followed by a 4-byte data footer at the >> end. >> >> The MAC-PHY shall support a default data chunk payload size of 64 bytes. >> Data chunk payload sizes of 32, 16, or 8 bytes may also be supported. The >> data chunk payload is always a multiple of 4 bytes. >> >> The 4-byte data header occurs at the beginning of each transmit data >> chunk on MOSI and the 4-byte data footer occurs at the end of each >> receive data chunk on MISO. The data header and footer contain the >> information needed to determine the validity and location of the transmit >> and receive frame data within the data chunk payload. Ethernet frames >> shall be aligned to a 32-bit boundary within the data chunk payload. >> >> Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@xxxxxxxxxxxxx> > > Hi Parthiban, > > this patch seems to introduce new Sparse warnings. > Please consider addressing those, and ideally the warnings > flagged in the existing oa_tc6.c code. Sure, will check it in the next revision. Best Regards, Parthiban V > > Thanks in advance! >
