Re: [PATCH 4/6] arm64: dts: qcom: sm4450: Add apps_rsc and cmd_db node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





在 9/8/2023 4:10 PM, Krzysztof Kozlowski 写道:
On 08/09/2023 08:58, Tengfei Fan wrote:
From: Ajit Pandey <quic_ajipan@xxxxxxxxxxx>

Add apps_rsc node and cmd_db memory region for sm4450.

Signed-off-by: Ajit Pandey <quic_ajipan@xxxxxxxxxxx>
Signed-off-by: Tengfei Fan <quic_tengfan@xxxxxxxxxxx>
---
  arch/arm64/boot/dts/qcom/sm4450.dtsi | 34 ++++++++++++++++++++++++++++
  1 file changed, 34 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm4450.dtsi b/arch/arm64/boot/dts/qcom/sm4450.dtsi
index c4e5b33f5169..eb544d875806 100644
--- a/arch/arm64/boot/dts/qcom/sm4450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm4450.dtsi
@@ -5,6 +5,7 @@
#include <dt-bindings/gpio/gpio.h>
  #include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/soc/qcom,rpmh-rsc.h>
/ {
  	interrupt-parent = <&intc>;
@@ -328,6 +329,18 @@
  		};
  	};
+ reserved_memory: reserved-memory {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		aop_cmd_db_mem: cmd-db@80860000 {
+			compatible = "qcom,cmd-db";
+			reg = <0x0 0x80860000 0x0 0x20000>;
+			no-map;
+		};
+	};
+
  	soc: soc@0 {
  		#address-cells = <2>;
  		#size-cells = <2>;
@@ -335,6 +348,27 @@
  		dma-ranges = <0 0 0 0 0x10 0>;
  		compatible = "simple-bus";
+ apps_rsc: rsc@17a00000 {
+			label = "apps_rsc";

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

+			compatible = "qcom,rpmh-rsc";

compatible is always the first property. reg/reg-names/ranges follow.
yes, dtbs_check verify done, maybe miss this error, will update this sequence.



Best regards,
Krzysztof


--
Thx and BRs,
Tengfei Fan



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux