On 9/6/23 18:20, Krzysztof Kozlowski wrote:
External email : Please do not click links or open attachments until you
have verified the sender or the content.
On 06/09/2023 12:15, Macpaul Lin wrote:
+
+wifi_3v3: wifi-3v3-regulator {
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.
This keeps a format with -regulator is because I've found some other use
cases. It seems "-regulator" or "regulator-" could be arbitrary. I'm not
sure if it is a new guideline for regulator's node. If there is in the
devicetree document, maybe I just missed it?
What is the point to name in the same DTS some of the regulators
"regulator-foo" and some "foo-regulator"?
Best regards,
Krzysztof
It looks like I've miss the point of previous review comment.
Updated new patch in v3 series.
Thanks
Macpaul Lin