On 9/6/23 17:34, Krzysztof Kozlowski wrote:
External email : Please do not click links or open attachments until you
have verified the sender or the content.
On 06/09/2023 11:25, Macpaul Lin wrote:
+edp_panel_fixed_12v: regulator-1 {
+compatible = "regulator-fixed";
+regulator-name = "edp_backlight_12v";
+regulator-min-microvolt = <12000000>;
+regulator-max-microvolt = <12000000>;
+enable-active-high;
+gpio = <&pio 96 GPIO_ACTIVE_HIGH>;
+pinctrl-names = "default";
+pinctrl-0 = <&edp_panel_12v_en_pins>;
+};
+
+backlight_lcd0: backlight-lcd0 {
+compatible = "pwm-backlight";
+pwms = <&disp_pwm0 0 500000>;
+enable-gpios = <&pio 47 GPIO_ACTIVE_HIGH>;
+brightness-levels = <0 1023>;
+num-interpolated-steps = <1023>;
+default-brightness-level = <576>;
+};
+
+backlight_lcd1: backlight-lcd1 {
+compatible = "pwm-backlight";
+pwms = <&disp_pwm1 0 500000>;
+enable-gpios = <&pio 46 GPIO_ACTIVE_HIGH>;
+brightness-levels = <0 1023>;
+num-interpolated-steps = <1023>;
+default-brightness-level = <576>;
+};
+
+keys: gpio-keys {
+compatible = "gpio-keys";
+
+button-volume-up {
+wakeup-source;
+debounce-interval = <100>;
+gpios = <&pio 106 GPIO_ACTIVE_LOW>;
+label = "volume_up";
+linux,code = <KEY_VOLUMEUP>;
+};
+};
+
+can_clk: can-clk {
+compatible = "fixed-clock";
+#clock-cells = <0>;
+clock-frequency = <20000000>;
+clock-output-names = "can-clk";
+};
+
+wifi_3v3: wifi-3v3-regulator {
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.
This keeps a format with -regulator is because I've found some other use
cases. It seems "-regulator" or "regulator-" could be arbitrary. I'm not
sure if it is a new guideline for regulator's node. If there is in the
devicetree document, maybe I just missed it?
However if this is for the purpose of keeping the DTS format tidy, I
will update it in the next version, also fix another
"usb-otg-vbus-regulator" node.
arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
a1d3281450ab2 (Christopher Obbard 2023-01-09 16:58:01 +0100 46)
vcc5v0_sys: vcc5v0-sys-regulator {
arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi
523adb553573d (Chris Morgan 2022-09-06 16:03:24 -0500 256)
vcc_wifi: regulator-vcc-wifi {
Thank you.
Best regards,
Krzysztof
Thanks.
Macpaul Lin
