Re: [PATCH v5 4/5] remoteproc: k3: Split out functions common with M4 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mathieu,

On 8/29/23 14:47, Mathieu Poirier wrote:
Signed-off-by: Martyn Welch<martyn.welch@xxxxxxxxxxxxx>
Signed-off-by: Hari Nagalla<hnagalla@xxxxxx>
---
Changes since v2:
  - New patch (reordered refactored from v2)

Changes since v3:
  - Removed "ipc_only" element from k3_rproc structure
  - Refactored to bring 3 more common functions
Changes since v4:
  - None

  drivers/remoteproc/Makefile               |   2 +-
  drivers/remoteproc/ti_k3_common.c         | 513 +++++++++++++++++++
  drivers/remoteproc/ti_k3_common.h         | 103 ++++
  drivers/remoteproc/ti_k3_dsp_remoteproc.c | 598 ++--------------------
  4 files changed, 646 insertions(+), 570 deletions(-)
  create mode 100644 drivers/remoteproc/ti_k3_common.c
  create mode 100644 drivers/remoteproc/ti_k3_common.h
This patch is hard to follow because of all the things it does.  Please do the
structures in one patch and the functions in another.

I will re-structure the patches as you suggested for driver and also separate the device tree node patches to avoid clutter.

Thanks



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux