Yo, Two minor nits that look like copy-paste duplication of the same problems in the syscon-reboot binding. On Fri, Sep 01, 2023 at 02:00:55PM +0200, Krzysztof Kozlowski wrote: > Just like syscon-reboot device, the syscon-poweroff is supposed to be a > child of syscon node, thus we can take the same approach as > syscon-poweroff: deprecate the 'regmap' field in favor of taking it from > the parent's node. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > --- > > See also syscon-regmap: > https://lore.kernel.org/all/20200526135102.21236-1-Sergey.Semin@xxxxxxxxxxxxxxxxxxxx/ > --- > .../bindings/power/reset/syscon-poweroff.yaml | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml > index 3412fe7e1e80..3c58f8251882 100644 > --- a/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml > +++ b/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml > @@ -15,6 +15,9 @@ description: |+ > defined by the register map pointed by syscon reference plus the offset > with the value and mask defined in the poweroff node. > Default will be little endian mode, 32 bit access only. > + The SYSCON registers map is normally retrieved from the parental dt-node. So s/registers/register/, no? > + the SYSCON poweroff node should be represented as a sub-node of a "syscon", > + "simple-mfd" node. > > properties: > compatible: > @@ -30,7 +33,10 @@ properties: > > regmap: > $ref: /schemas/types.yaml#/definitions/phandle > - description: Phandle to the register map node. > + deprecated: true > + description: > + Phandle to the register map node. This property is deprecated in favor of > + the syscon-poweroff node been a child of a system controller node. s/been/being/ Otherwise, Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> Thanks, Conor. > > value: > $ref: /schemas/types.yaml#/definitions/uint32 > @@ -38,7 +44,6 @@ properties: > > required: > - compatible > - - regmap > - offset > > additionalProperties: false > @@ -56,7 +61,6 @@ examples: > - | > poweroff { > compatible = "syscon-poweroff"; > - regmap = <®mapnode>; > offset = <0x0>; > mask = <0x7a>; > }; > -- > 2.34.1 >
Attachment:
signature.asc
Description: PGP signature