On 01/09/2023 11:27, Binbin Zhou wrote:
> Hi Krzysztof:
>
>
> On Fri, Sep 1, 2023 at 5:06 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>>
>> On 31/08/2023 13:43, Binbin Zhou wrote:
>>> required:
>>> - compatible
>>> - reg
>>> @@ -54,4 +66,18 @@ examples:
>>> interrupt-parent = <&liointc1>;
>>> interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
>>> loongson,suspend-address = <0x0 0x1c000500>;
>>> +
>>> + syscon-reboot {
>>> + compatible = "syscon-reboot";
>>> + offset = <0x30>;
>>> + mask = <0x1>;
>>> + };
>>> +
>>> + syscon-poweroff {
>>> + compatible = "syscon-poweroff";
>>> + regmap = <&pmc>;
>>
>> ???
>
> I did notice that commit [1] changed "regmap" to "unrequired" for
> "syscon-reboot", but "syscon-poweroff" did not do the same.
> So, at least under the current "syscon-poweroff" rule, "regmap" is "required".
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml?h=v6.5#n41
>
> I had my doubts before, but seeing that some dts do have
> "syscon-poweroff" as a separate node, I assumed there was a
> difference.
>
> commit[1]: 2140d68d69d4 dt-bindings: power: reset: Unrequired regmap
> property in syscon-reboot node
>
You are right. I wonder why Serge did not change others.
Looks good, thanks for clarification.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Best regards,
Krzysztof
