On 31/08/2023 13:43, Binbin Zhou wrote: > required: > - compatible > - reg > @@ -54,4 +66,18 @@ examples: > interrupt-parent = <&liointc1>; > interrupts = <11 IRQ_TYPE_LEVEL_LOW>; > loongson,suspend-address = <0x0 0x1c000500>; > + > + syscon-reboot { > + compatible = "syscon-reboot"; > + offset = <0x30>; > + mask = <0x1>; > + }; > + > + syscon-poweroff { > + compatible = "syscon-poweroff"; > + regmap = <&pmc>; ??? This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. Best regards, Krzysztof