On 28/08/2023 16:04, Shenwei Wang wrote: >>> Are you suggesting to move the regulator-pd to the imx directory and >>> add a company prefix to the compatible string? >> >> There is no such part of iMX processor as such regulator-power-domain, so I >> don't recommend that approach. DTS nodes represent hardware, not your SW >> layers. >> > > That's not always the case, as we do sometimes need a virtual device. > As an example, the "regulator-fixed" acts as a software abstraction layer to create virtual regulator > devices by interfacing with the underlying GPIO drivers. Not true. This is a real regulator device. Real hardware on the board. You can even see and touch it. > Similarly, "regulator-pd" provides a software abstraction layer for virtual PD devices built on > top of existing regulator drivers. This is not related to regulator-fixed at all. > When looking at the conceptual purpose, regulator-fixed and regulator-pd are comparable in > that they both offer software abstraction layers for virtual devices." No. regulator-fixed is a real device. Yours is not. Best regards, Krzysztof
