Re: [PATCH 1/2] dt-bindings: power: Add regulator-pd yaml file

[Shenwei Wang <shenwei.wang@xxxxxxx>]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Saturday, August 26, 2023 12:32 PM
> To: Shenwei Wang <shenwei.wang@xxxxxxx>; Ulf Hansson
> <ulf.hansson@xxxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>;
> Liam Girdwood <lgirdwood@xxxxxxxxx>; Mark Brown <broonie@xxxxxxxxxx>;
> imx@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> dl-linux-imx <linux-imx@xxxxxxx>
> Subject: [EXT] Re: [PATCH 1/2] dt-bindings: power: Add regulator-pd yaml file
> >                                                             >
> >                                                             >         regulator-number = <2>;
> >                                                             >         regulator-0-supply = <&reg1>;
> >                                                             >         regulator-1-supply = <&reg2>;
> >     };                                                                    };
> >
> > Are you suggesting to move the regulator-pd to the imx directory and
> > add a company prefix to the compatible string?
> 
> There is no such part of iMX processor as such regulator-power-domain, so I
> don't recommend that approach. DTS nodes represent hardware, not your SW
> layers.
> 

That's not always the case, as we do sometimes need a virtual device. 
As an example, the "regulator-fixed" acts as a software abstraction layer to create virtual regulator 
devices by interfacing with the underlying GPIO drivers.
Similarly, "regulator-pd" provides a software abstraction layer for virtual PD devices built on 
top of existing regulator drivers.
When looking at the conceptual purpose, regulator-fixed and regulator-pd are comparable in 
that they both offer software abstraction layers for virtual devices."

Thanks,
Shenwei

> Best regards,
> Krzysztof