On 25.08.2023 11:12, Devi Priya wrote:
> Add Networking Sub System Clock Controller(NSSCC) driver for ipq9574 based
> devices.
>
> Signed-off-by: Devi Priya <quic_devipriy@xxxxxxxxxxx>
> ---
[...]
> + [UBI3_CLKRST_CLAMP_ENABLE] = { 0x28A04, 9 },
Please make all hex lowercase.
[...]
> + [PPE_FULL_RESET] = { 0x28A08, 0, 1, 0x1E0000 },
{ .reg = 0x28a08, .bitmask = GENMASK(foo,bar) },
[...]
> + ret = devm_pm_runtime_enable(&pdev->dev);
> + if (ret < 0)
> + return ret;
> +
> + ret = devm_pm_clk_create(&pdev->dev);
> + if (ret < 0)
> + return ret;
> +
> + ret = of_pm_clk_add_clk(&pdev->dev, "nssnoc_nsscc");
> + if (ret < 0) {
> + dev_err(&pdev->dev, "Failed to acquire nssnoc_nsscc clock\n");
> + return ret;
dev_err_probe, everywhere?
Konrad
