On Fri, Aug 25, 2023 at 2:41 AM Robert Marko <robimarko@xxxxxxxxx> wrote: > On Tue, 22 Aug 2023 at 17:38, Mukesh Ojha <quic_mojha@xxxxxxxxxxx> wrote: > > On 8/16/2023 10:15 PM, Robert Marko wrote: > > > + ret = qcom_scm_call(__scm->dev, &desc, &res); > > > > Would you not be wanting this call to be atomic ? > > This is implemented based off the downstream 5.4 kernel as I dont have > the SCM docs > so I dont know if its even supported in the atomic version. More than that, it's known *not* to be properly supported on one such applicable device: Subject: [RFC] qcom_scm: IPQ4019 firmware does not support atomic API? https://lore.kernel.org/linux-arm-kernel/20200913201608.GA3162100@bDebian/ I still haven't gotten a solution to *that* problem upstream, but it'd be nice not to make it worse. Brian