Hi Rob,
On Wed, Aug 23, 2023 at 6:44 PM Rob Herring <robh+dt@xxxxxxxxxx> wrote:
> On Wed, Aug 23, 2023 at 7:52 AM Geert Uytterhoeven
> <geert+renesas@xxxxxxxxx> wrote:
> >
> > Miscellaneous fixes and improvements to the overlay_pci_node:
> > - Add missing /plugin/,
>
> Is it really missing if it wasn't needed since no unresolved phandles?
> I guess the sugar syntax needs, too?
It's indeed needed for the &{...} reference using sugar syntax.
> > - Convert to sugar syntax,
> > - Add missing blank lines between properties and subnodes.
> >
> > As sugar syntax does not support empty target paths, the test device is
> > added to /testcase-data/overlay-node instead.
>
> There's a definite need for unspecified target paths. It's probably
> something of an oversight that a blank path was even allowed. I don't
> think putting in the wrong path is a good solution. There should be
> perhaps more discussion if a blank path is the right thing and then
> how to make the sugar syntax output a blank path.
The path will not be used anyway, as it will be overwritten by passing
the new base parameter of of_overlay_fdt_apply().
So "/" could be used as well.
I have more comments, but I'll give them as a reply to the original
patch introducing the base parameter.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
