Re: [PATCH] [RFC] of: unittest: overlay_pci_node: Fix overlay style

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 23, 2023 at 7:52 AM Geert Uytterhoeven
<geert+renesas@xxxxxxxxx> wrote:
>
> Miscellaneous fixes and improvements to the overlay_pci_node:
>   - Add missing /plugin/,

Is it really missing if it wasn't needed since no unresolved phandles?
I guess the sugar syntax needs, too?

>   - Convert to sugar syntax,
>   - Add missing blank lines between properties and subnodes.
>
> As sugar syntax does not support empty target paths, the test device is
> added to /testcase-data/overlay-node instead.

There's a definite need for unspecified target paths. It's probably
something of an oversight that a blank path was even allowed. I don't
think putting in the wrong path is a good solution. There should be
perhaps more discussion if a blank path is the right thing and then
how to make the sugar syntax output a blank path.

Rob




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux