Hi Krzysztof, On 24/08/23 12:13 pm, Krzysztof Kozlowski wrote: > On 23/08/2023 13:32, MD Danish Anwar wrote: >> Add a DT binding document for the ICSS Industrial Ethernet Peripheral(IEP) >> hardware. IEP supports packet timestamping, PTP and PPS. >> >> Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > Really? Where? Conor gave his RB tag for patch 1 and 2 in v4 https://lore.kernel.org/all/20230814-quarters-cahoots-1fbd583baad9@spud/ > >> Reviewed-by: Roger Quadros <rogerq@xxxxxxxxxx> > > Now you are making things up. Please stop faking tags. Roger provided his RB tag in v5 for all the patches https://lore.kernel.org/all/5d077342-435f-2829-ba2a-cdf763b6b8e1@xxxxxxxxxx/ > >> Reviewed-by: Simon Horman <horms@xxxxxxxxxx> > > Where? > Simon gave his RB tag for all the patches of this series in v5 https://lore.kernel.org/all/ZN9aSTUOT+SKESQS@xxxxxxxxxxxx/ >> Signed-off-by: MD Danish Anwar <danishanwar@xxxxxx> >> --- >> .../devicetree/bindings/net/ti,icss-iep.yaml | 61 +++++++++++++++++++ >> 1 file changed, 61 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/ti,icss-iep.yaml >> >> diff --git a/Documentation/devicetree/bindings/net/ti,icss-iep.yaml b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml >> new file mode 100644 >> index 000000000000..75668bea8614 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml >> @@ -0,0 +1,61 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/ti,icss-iep.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Texas Instruments ICSS Industrial Ethernet Peripheral (IEP) module >> + >> +maintainers: >> + - Md Danish Anwar <danishanwar@xxxxxx> >> + >> +properties: >> + compatible: >> + oneOf: >> + - items: >> + - enum: >> + - ti,am642-icss-iep >> + - ti,j721e-icss-iep >> + - const: ti,am654-icss-iep >> + >> + - const: ti,am654-icss-iep >> + >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + description: phandle to the IEP source clock >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + > > Drop stray blank line > >> + /* AM65x */ >> + icssg0_iep0: iep@2e000 { >> + compatible = "ti,am654-icss-iep"; >> + reg = <0x2e000 0x1000>; >> + clocks = <&icssg0_iepclk_mux>; >> + }; > > Choose one example. > > > Best regards, > Krzysztof > -- Thanks and Regards, Danish.