On 23/08/2023 08:20, Yu Tu wrote: > > > On 2023/8/23 13:43, Krzysztof Kozlowski wrote: >> >> [ EXTERNAL EMAIL ] >> >> On 23/08/2023 04:24, Yu Tu wrote: >>> >>> >>> On 2023/8/23 0:32, Krzysztof Kozlowski wrote: >>>> [ EXTERNAL EMAIL ] >>>>> On 22/08/2023 10:27, Yu Tu wrote: >>>>> Add the S4 PLL clock controller dt-bindings in the S4 SoC family. >>>>> >>>>> Signed-off-by: Yu Tu <yu.tu@xxxxxxxxxxx> >>>> >>>> Lovely. I sent youa friendly reminder at v8 which turns our you >>>> ignored. You keep ignoring, I will start ignoring as well from now on. >>> >>> Hi Krzysztof， >>> >>> Sorry. I did not forget the friendly reminder in v8, I consulted you for >>> this at the time, so I re-sent V9 after adding the tag. Because it was >>> just "meson" that was removed. But V10 is based on Neil's patch, which I >>> think is a bit of a change. So I didn't dare add it. Instead of >>> forgetting your reminder. >>> >>> So what should I do, I'll follow your advice exactly. >> >> I don't think there was much difference between the version, which >> received the review, and the current patch. Otherwise your changelog >> should say that you drop Rb tag. Rebasing of something somewhere is not >> the reason, so please describe what are the differences in the patch? > > The current patch and V9 patch difference is mainly based on Neil patch > I put "include/dt - bindings/clock/amlogic,s4-pll-clkc.h" this document > describes the clock index all exposed. Adding one include is insignificant change, thus any Rb tags should stay. > > Next, I should add Rob's tag and resend it. If you have any other > suggestions, please tell me and I will strictly follow your suggestions. I cannot add someone's tag, thus on your next version you must include it. I told this last time. Best regards, Krzysztof
