On Tue, Aug 22, 2023 at 12:52 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Rob, > > On Tue, Aug 22, 2023 at 5:32 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Tue, Aug 22, 2023 at 12:22:34PM +0200, Geert Uytterhoeven wrote: > > > Run the test for the overlay apply/revert sequence three times, to > > > test if there are unbalanced of_node_put() calls causing reference > > > counts to become negative. > > > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > > --- > > > This is a reproducer for the issue fixed by commit 7882541ca06d51a6 > > > ("of/platform: increase refcount of fwnode") in dt/linus. > > > > Is this necessary? There were WARN backtraces without that fix. > > Did you see them? Yes, but that was also with your series applied. When I tested the fix, I had dropped that, so maybe your series triggered it too. Rob