Re: [PATCH] of: unittest: Run overlay apply/revert sequence three times

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rob,

On Tue, Aug 22, 2023 at 5:32 PM Rob Herring <robh@xxxxxxxxxx> wrote:
> On Tue, Aug 22, 2023 at 12:22:34PM +0200, Geert Uytterhoeven wrote:
> > Run the test for the overlay apply/revert sequence three times, to
> > test if there are unbalanced of_node_put() calls causing reference
> > counts to become negative.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > ---
> > This is a reproducer for the issue fixed by commit 7882541ca06d51a6
> > ("of/platform: increase refcount of fwnode") in dt/linus.
>
> Is this necessary? There were WARN backtraces without that fix.

Did you see them?
Peng saw them with the out-of-tree jailhouse hypervisor enable/disable
test, and I saw them with the out-of-tree overlay configfs patches.
I am not aware of any in-tree kernel code triggering them.  If we
would have had this in the unittests, I would have noticed this
regression earlier...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux