Re: [PATCH V2 1/4] ARM: dts: sun8i: V3: add alias to cpu node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Aug 19, 2023 at 11:00:59PM +0100, Andre Przywara wrote:
> On Fri, 18 Aug 2023 22:21:02 -0500
> Chris Morgan <macroalpha82@xxxxxxxxx> wrote:
> 
> Hi Chris,
> 
> > From: Chris Morgan <macromorgan@xxxxxxxxxxx>
> > 
> > Add alias to CPU node to allow board specific CPU information to be
> > added.
> > 
> > Signed-off-by: Chris Morgan <macromorgan@xxxxxxxxxxx>
> > ---
> >  arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi b/arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi
> > index 3b9a282c2746..2b76a5b8ec19 100644
> > --- a/arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi
> > +++ b/arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi
> > @@ -71,7 +71,7 @@ cpus {
> >  		#address-cells = <1>;
> >  		#size-cells = <0>;
> >  
> > -		cpu@0 {
> > +		cpu0: cpu@0 {
> 
> That's really a nitpick, but the V3s is a single core, so I think we
> should just use "cpu" as the alias.

Will do. Thank you.

> 
> Cheers,
> Andre
> 
> >  			compatible = "arm,cortex-a7";
> >  			device_type = "cpu";
> >  			reg = <0>;
> 



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux