On Mon, Aug 21, 2023 at 9:06 AM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Sun, Aug 20, 2023 at 04:05:16PM -0500, Adam Ford wrote: > > On Sun, Aug 20, 2023 at 3:33 PM Krzysztof Kozlowski > > <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > > > > > On 20/08/2023 22:32, Krzysztof Kozlowski wrote: > > > > On 20/08/2023 19:56, Adam Ford wrote: > > > >> The i.MX8MP appears to have the same easrc support as the Nano, so > > > >> add imx8mp as an option with a fallback to imx8mn. > > > >> > > > >> Signed-off-by: Adam Ford <aford173@xxxxxxxxx> > > > >> > > > >> diff --git a/Documentation/devicetree/bindings/sound/fsl,easrc.yaml b/Documentation/devicetree/bindings/sound/fsl,easrc.yaml > > > >> index bdde68a1059c..2d53b3b10f2c 100644 > > > >> --- a/Documentation/devicetree/bindings/sound/fsl,easrc.yaml > > > >> +++ b/Documentation/devicetree/bindings/sound/fsl,easrc.yaml > > > >> @@ -14,7 +14,11 @@ properties: > > > >> pattern: "^easrc@.*" > > > >> > > > >> compatible: > > > >> - const: fsl,imx8mn-easrc > > > >> + oneOf: > > > >> + - items: > > > >> + - enum: > > > >> + - fsl,imx8mp-easrc > > > >> + - const: fsl,imx8mn-easrc > > > > > > > > You need here also const for fsl,imx8mn-easrc, otherwise you do not > > > > allow it alone. Test it for fsl,imx8mn-easrc DTS - you will notice warnings. > > > > > > Actually, I see now Rob's report... you did not have to test DTS even. > > > It was enough to test your change and this test was missing :(. Please > > > test your changes before sending. > > > > For what it's worth, I did run 'make dt_binding_check', but I didn't > > run it with the extra flags from Rob's e-mail. The tool didn't return > > any errors. > > The error is not related to the '-m' (undocumented compatible) warning. > It is as Krzysztof said. I was able to replicate the message after I updated the schema. Is there any way we can add the dt_binding_check to the 'make help' menu? I do this so infrequently that I don't necessarily know what the proper flags are, and I sometimes forget to update the schema. I have seen others run into similar issues, so it seems like having it in the help menu might be beneficial to more people. adam > > Rob
