RE: [PATCH 1/2] arm64: dts: imx8mm-evk: Add VDDEXT_3V3 fixed regulator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday, August 18, 2023 10:06 PM Fabio Estevam <festevam@xxxxxxxxx> wrote:
> 
> Hi Liu,

Hi Fabio,

> 
> On Mon, Aug 14, 2023 at 5:07 AM Liu Ying <victor.liu@xxxxxxx> wrote:
> 
> > +       reg_vddext_3v3: regulator-vddext-3v3 {
> > +               compatible = "regulator-fixed";
> > +               regulator-name = "VDDEXT_3V3";
> > +               regulator-min-microvolt = <3300000>;
> > +               regulator-max-microvolt = <300000>;
> > +       };
> 
> Booting the dtb with this change will cause this regulator to be
> disabled as there is no consumer for it.

Software cannot control this regulator by any means.  It's on once
the board is powered on.  Do you mean it will be disabled in software
level if no consumer?  If that's the case, is the disablement harmful?

> 
> I suggest squashing both patches:

The patch looks self-contained to me.  Can we keep it as-is?

> 
> Tested-by: Fabio Estevam <festevam@xxxxxxxxx>

Thanks for your test!

Regards,
Liu Ying




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux