On 18/08/2023 21:46, Bjorn Andersson wrote: >>> >>> With this script, the workflow would be as simple as: >>> >>> 1. Generate patches using `git format-patch` >>> 2. Run `add-maintainer.py` on the above patches >>> 3. `git send-email` the patches. >> >> So one more unnecessary step (2). I don't think it is easier than my >> workflow. >> >> I just do only 1 and 3 and that's it. The simplest way ever. >> > > There's no get_maintainer.pl in either 1, or 3, so obviously this isn't > the only thing you do. > > Thanks for the link to your alias below, it's now clear that you don't > need an extra step in the procedure, if you only have your extra wrapper > around step 3. > > > I now also understand why you never ever have a cover-letter, something > Guru's proposed flow handles quite nicely. It's not related. I usually don't create cover letter from laziness, but pretty often I create them as well and my script/alias works there perfectly. Cover letter is just one more step: 1. git branch --edit-description 2. git format-patch --cover-letter (with format.coverFromDescription = subject in gitconfig) 3. git_send_email 0* No need to run any other tool, no need to add any maintainer entries (unless touching defconfig and specific soc@ stuff, but this is always the case regardless of tools). Really, that script proposed here is the unnecessary step. Rob's approach with git send-email identity required some work for cover-letter, but it was also running get_maintainer.pl per each patch, so recipients did not receive everything. Unless patchset is big, I prefer to send everything to everyone. > > > That said, b4 prep and b4 send seems like a better suggestion to those > who doesn't already have a workflow in place. Yes. Best regards, Krzysztof
