On 10/08/2023 20:55, Guru Das Srinagesh wrote: > On Aug 03 2023 01:23, Guru Das Srinagesh wrote: >> When pushing patches to upstream, the `get_maintainer.pl` script is used to >> determine whom to send the patches to. Instead of having to manually process >> the output of the script, add a wrapper script to do that for you. >> >> The add-maintainer.py script adds maintainers (and mailing lists) to a patch, >> editing it in-place. > > Could I request reviews from the other maintainers as well, please? Just to see > if I should continue working on this script or if the `b4` tool obviates the > need for such a script. I send a bit of patches but I use very simple workflow. It is really simple, so simple, that I was always surprised how people can make their life difficult with some complicated process to send patches... and then obviously skip some maintainers, because of that process. I almost always feed git send-email with addresses from scripts/get_maintainers.pl. This tool would not bring any benefits to my simple workflow. For newcomers, OTOH, I would either recommend simple workflow or just use b4. Why? Because if you cannot use git-send-email, then it means your email setup will make your life difficult and adding maintainers to existing patch won't help you. This tool depends on the command line and shell interface of scripts/get_maintainers.pl which is another reason why it might not be a good idea. Best regards, Krzysztof
