On Fri, Aug 18, 2023 at 11:31:35AM +0200, Krzysztof Kozlowski wrote:
> Where is any user of it? DTS, driver or 3rd party upstream open-source
> project?
>
Yes, for Geotab. We are working on bringing up a new BSP and we have tps25750
which doesn't have a driver in Linux yet. We developed the driver but I thought
I needed to get the dt-bindings accepted first before sending the patch for
the driver.
Sorry, this is my first time contributing to Linux. Maybe this question
was asked before but for some reason I couldn't find it.
What is usually the process? Should I upload the driver too?
>
> A nit, subject: drop second/last, redundant "binding for". The
> "dt-bindings" prefix is already stating that these are bindings.
>
> > + - ti,tps25750
>
> Blank line
>
> > + reg:
> > + interrupts:
> > + description: |
>
> Drop description
>
> > + interrupt-names:
> > + items:
> > + - const: irq
>
> Drop interrupt-names, it is useless in this form.
>
> > + firmware-name:
> > + description: |
> > + Should contain the name of the default patch binary
> > + file located on the firmware search path which is
> > + used to switch the controller into APP mode
>
> maxItems: 1
>
> > + tps25750: tps25750@21 {
>
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>
>
> > + compatible = "ti,tps25750";
> > + reg = <0x21>;
> > +
>
>
> Best regards,
> Krzysztof
>
Thanks for the review. I've addressed your comments in v2
Best Regards,
Abdel
