On 18/08/2023 01:52, Abdel Alkuor wrote: > From: Abdel Alkuor <abdelalkuor@xxxxxxxxxx> > > TPS25750 provides power negotiation and capabilities management > for USB Type-C applications. > > Signed-off-by: Abdel Alkuor <abdelalkuor@xxxxxxxxxx> Where is any user of it? DTS, driver or 3rd party upstream open-source project? A nit, subject: drop second/last, redundant "binding for". The "dt-bindings" prefix is already stating that these are bindings. > --- > .../devicetree/bindings/usb/ti,tps25750.yaml | 84 +++++++++++++++++++ > 1 file changed, 84 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/ti,tps25750.yaml > > diff --git a/Documentation/devicetree/bindings/usb/ti,tps25750.yaml b/Documentation/devicetree/bindings/usb/ti,tps25750.yaml > new file mode 100644 > index 000000000000..326c9c2f766b > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/ti,tps25750.yaml > @@ -0,0 +1,84 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/ti,tps25750.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments 25750 Type-C Port Switch and Power Delivery controller > + > +maintainers: > + - Abdel Alkuor <abdelalkuor@xxxxxxxxxx> > + > +description: | > + Texas Instruments 25750 Type-C Port Switch and Power Delivery controller > + > +properties: > + compatible: > + enum: > + - ti,tps25750 Blank line > + reg: > + maxItems: 1 > + > + interrupts: > + description: | Drop description > + maxItems: 1 > + > + interrupt-names: > + items: > + - const: irq Drop interrupt-names, it is useless in this form. > + > + firmware-name: > + description: | > + Should contain the name of the default patch binary > + file located on the firmware search path which is > + used to switch the controller into APP mode maxItems: 1 > + > + connector: > + type: object > + $ref: ../connector/usb-connector.yaml# > + description: > + Properties for usb c connector. > + required: > + - data-role > + > +required: > + - compatible > + - reg > + - interrupts > + - connector > + > +additionalProperties: true > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + tps25750: tps25750@21 { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "ti,tps25750"; > + reg = <0x21>; > + Best regards, Krzysztof
