On 8/9/23 18:50, Jisheng Zhang wrote:
> The IP can support up to 31 xgmac c22 addresses now.
>
> Signed-off-by: Jisheng Zhang <jszhang@xxxxxxxxxx>
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> index 3db1cb0fd160..e6d8e34fafef 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> @@ -40,7 +40,7 @@
> #define MII_XGMAC_WRITE (1 << MII_XGMAC_CMD_SHIFT)
> #define MII_XGMAC_READ (3 << MII_XGMAC_CMD_SHIFT)
> #define MII_XGMAC_BUSY BIT(22)
> -#define MII_XGMAC_MAX_C22ADDR 3
> +#define MII_XGMAC_MAX_C22ADDR 31
> #define MII_XGMAC_C22P_MASK GENMASK(MII_XGMAC_MAX_C22ADDR, 0)
> #define MII_XGMAC_PA_SHIFT 16
> #define MII_XGMAC_DA_SHIFT 21
Recent commit 10857e677905 ("net: stmmac: XGMAC support for mdio C22
addr > 3") already addressed this in a different way. As per Synopsis
IP team until version 2.2, XGMAC supports only MDIO devices 0 - 3. An
XGMAC IP version check is newly added for the same reason. I think this
covers your commit also. Please have a look and if so you can drop this
commit.
BR,
Rohan
