On 09/08/2023 20:02, James Ogletree wrote: >>> + if (cs40l50->vibe_workqueue) { >>> + flush_workqueue(cs40l50->vibe_workqueue); >>> + destroy_workqueue(cs40l50->vibe_workqueue); >>> + } >>> + >>> + gpiod_set_value_cansleep(cs40l50->reset_gpio, 1); >>> + regulator_bulk_disable(ARRAY_SIZE(cs40l50_supplies), cs40l50_supplies); >>> + >>> + return 0; >>> +} >>> +EXPORT_SYMBOL_GPL(cs40l50_remove); >>> + >>> +MODULE_DESCRIPTION("CS40L50 Advanced Haptic Driver"); >>> +MODULE_AUTHOR("James Ogletree, Cirrus Logic Inc. <james.ogletree@xxxxxxxxxx>"); >>> +MODULE_LICENSE("GPL"); >> >> I don't think this is a module. > > It can be compiled as a module with CONFIG_INPUT_CS40L50=m. However, there is a > typo in the Kconfig entry description: the module will be called “cs40l50” not “cs40l50-core”. > That will be fixed. Really, *this* unit file can be compiled as module? Where is the module_xxx_driver() then? Best regards, Krzysztof