On Tue, Aug 08, 2023 at 02:36:46PM -0700, Bjorn Andersson wrote:
> On Fri, Jul 21, 2023 at 08:59:30PM -0700, Bjorn Andersson wrote:
> > On Tue, Jul 18, 2023 at 10:46:10AM -0400, Eric Chanudet wrote:
> > > diff --git a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
> > [..]
> > > +&pmm8540a_sdam_7 {
> > > + status = "okay";
> > > +
> > > + rtc_offset: rtc-offset@ac {
> > > + reg = <0xac 0x4>;
> >
> > I'm still trying to get confirmation that this is a good choice.
> >
>
> I'm recommended that you use 0xa0 from SDAM2, "preferably in the second
> PMM8540", instead.
>
> Can you please give this a try, Eric?
That worked, the offset was saved and read back upon rebooting from the
system. I did get a defer on some tests waiting for the second pmic,
which I presume is not surprising:
[ 0.257064] spmi spmi-0: PMIC arbiter version v5 (0x50020000)
[ 8.340386] platform c440000.spmi:pmic@0:rtc@6000: error -EPROBE_DEFER: wait for supplier /soc@0/spmi@c440000/pmic@4/nvram@b110/rtc-offset@a0
[ 8.393201] platform c440000.spmi:pmic@0:rtc@6000: error -EPROBE_DEFER: wait for supplier /soc@0/spmi@c440000/pmic@4/nvram@b110/rtc-offset@a0
[ 8.465407] rtc-pm8xxx c440000.spmi:pmic@0:rtc@6000: registered as rtc0
[ 8.479612] rtc-pm8xxx c440000.spmi:pmic@0:rtc@6000: setting system clock to 2023-08-09T19:16:08 UTC (1691608568)
Here is the v3 with the changes:
https://lore.kernel.org/linux-arm-msm/20230809203506.1833205-1-echanude@xxxxxxxxxx
Thank you again for the feedback.
--
Eric Chanudet
