On 09/08/2023 09:28, Yinbo Zhu wrote:
>>
>>> - gpio-ranges
>>> - interrupts
>>>
>>> @@ -49,11 +82,16 @@ examples:
>>> #include <dt-bindings/interrupt-controller/irq.h>
>>>
>>> gpio0: gpio@1fe00500 {
>>> - compatible = "loongson,ls2k-gpio";
>>> + compatible = "loongson,ls2k1000-gpio";
>>> reg = <0x1fe00500 0x38>;
>>> ngpios = <64>;
>>> #gpio-cells = <2>;
>>> gpio-controller;
>>> + loongson,gpio-conf-offset = <0>;
>>> + loongson,gpio-in-offset = <0x20>;
>>> + loongson,gpio-out-offset = <0x10>;
>>> + loongson,gpio-ctrl-mode = <0>;
>>> + loongson,gpio-inten-offset = <0x30>;
>>
>> I still think that you just embed the programming model into properties,
>> instead of using dedicated compatible for different blocks. It could be
>> fine, although I would prefer to check it with your DTS
>
> Okay, I got it, and if I understand correctly, you seem to agree with
> me adding attributes like this.
>
> And, if using this method that programming model into dts properites,
> then when adding a new platform's GPIO, there is no longer a need to
> modify the driver because gpio controller is compatible and different
> platform can use a same compatible.
Uhu, so there we are. You use this method now to avoid new compatibles.
No, therefore I do not agree.
>
>>
>> Where is your DTS?
>
>
> Sorry, the dts containing gpio nodes are only available in the product
> code and have not been sent to the community yet.
Does not help to convince us, but it is your right. With this and above
explanation, my answer is no - NAK.
Best regards,
Krzysztof
