On 08/08/2023 06:32, Thomas McKahan wrote: >>> + >>> + regulators { >>> + vdd_gpu_s0: vdd_gpu_mem_s0: dcdc-reg1 { >>> + regulator-boot-on; >> >> Boolean properties are not first, but last. regulator-name is the first >> one. This odd style... >> > > I agree, however it seems the norm in Rockchip devices. This will > become an outlier in Rockchip but fall in line with the general case. > I'll put it in V2 with the other mentioned fixes unless a conflicting > opinion is expressed. OK, no need to change then. Best regards, Krzysztof