On 02/08/2023 14:37, Konrad Dybcio wrote: > From: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxxx> > > Add the bindings for the CPR3 driver to the documentation. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxxx> > [Konrad: Make binding check pass; update AGdR's email] > Tested-by: Jeffrey Hugo <quic_jhugo@xxxxxxxxxxx> > Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> > --- > .../devicetree/bindings/soc/qcom/qcom,cpr3.yaml | 291 +++++++++++++++++++++ > 1 file changed, 291 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml > new file mode 100644 > index 000000000000..d797abc5d5fe > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml > @@ -0,0 +1,291 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/soc/qcom/qcom,cpr3.yaml#"; Drop quotes. It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Core Power Reduction v3/v4/Hardened (CPR3, CPR4, CPRh) > + > +description: > + CPR (Core Power Reduction) is a technology to reduce core power of a CPU > + (or another device). Each OPP of a device corresponds to a "corner" that > + has a range of valid voltages for a particular frequency. > + The CPR monitors dynamic factors such as temperature, etc. and suggests > + or (in the CPR-hardened case) applies voltage adjustments to save power > + and meet silicon characteristic requirements for a given chip unit. > + > +maintainers: > + - AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> > + > +properties: > + compatible: > + oneOf: > + - description: CPRv3 controller Nit, since you are going to resend, then: Drop description, it's the same as compatible. > + items: > + - const: qcom,cpr3 > + - description: CPRv4 controller Ditto Best regards, Krzysztof
