On Tue, Aug 08, 2023 at 01:03:33PM +0200, Duje Mihanović wrote: > On Tuesday, August 8, 2023 12:46:23 PM CEST Conor Dooley wrote: > > On Tue, Aug 08, 2023 at 12:41:22PM +0200, Duje Mihanović wrote: > > > They are used by the clock driver when calling mmp_clk_init which then > uses > > > that as the size of a struct clk array it allocates. In retrospect, 50 for > > > each block may be too much as from what I can tell by reading the > > > mmp_register_* functions (number of clocks + 1) for each block should be > > > enough, anything less than that causes a null pointer dereference sometime > > > during clock initialization. > > > > I think you might have misread my question, I'm not really interested in > > the implementation detail of the driver. If these are not used in > > devicetree, remove them - otherwise they are being needlessly added to > > the ABI. > > Should I also do this in the rest of the MMP clock drivers? Krzysztof has just done it for all of the Samsung ones! I think it wouldn't be a bad idea to get rid of them else where & new additions should definitely be avoided.
Attachment:
signature.asc
Description: PGP signature
