On Tue, Aug 08, 2023 at 09:22:24AM +0200, Marcus Folkesson wrote: > On Mon, Aug 07, 2023 at 06:53:21PM +0300, Andy Shevchenko wrote: > > On Mon, Aug 07, 2023 at 09:18:31AM +0200, Marcus Folkesson wrote: ... > > > - ret = mcp3911_config(adc); > > > + ret = device_property_read_u32(&adc->spi->dev, "microchip,device-addr", &adc->dev_addr); > > > > Why not spi->dev? Ditto for other uses like this. > > After all, I think it is better to stick sith adc->spi-dev to be > consistent with the rest of the probe function. Change to spi->dev > should probably be a seperate patch. > Do you agree? Make sure you first switch to use shorter form and then add this one. In that case I agree. -- With Best Regards, Andy Shevchenko
