On Wed, Aug 2, 2023 at 9:12 AM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> On Tue, Aug 01, 2023 at 03:54:47PM -0600, Rob Herring wrote:
> > The changeset code checks for a property in the deadprops list when
> > adding/updating a property, but of_add_property() and
> > of_update_property() do not. As the users of these functions are pretty
> > simple, they have not hit this scenario or else the property lists
> > would get corrupted.
>
> ...
>
> Seems like this...
>
> > + /* If the property is in deadprops then it must be removed */
> > + for (next = &np->deadprops; *next; next = &(*next)->next) {
> > + if (*next == prop) {
> > + *next = prop->next;
> > + break;
> > + }
> > + }
>
> > prop->next = NULL;
>
> ...
>
> > + for (next = &np->deadprops; *next; next = &(*next)->next) {
> > + if (*next == newprop) {
> > + *next = newprop->next;
> > + newprop->next = NULL;
> > + break;
> > + }
> > + }
>
> ...is a dup of this. Are you planing to have a helper or at least conditional
> for_each_*() macro for them?
At least the latter would be more clean-up than I want to do here
because this will be backported to stable. We have an iterator for
properties list, but note how this iterates on the "next" ptr address.
So it's a bit different from the normal iterators.
I'll go ahead and add a helper.
Rob
