Geert's locking fix[1] prompted my closer look at __of_changeset_entry_apply() and related functions. The result is a couple of fixes I found and some refactoring that unifies the "old API" and the changeset API. [1] https://lore.kernel.org/all/c593d8389352c574b5be69d4ca4810da13326a50.1690533838.git.geert+renesas@xxxxxxxxx/ Signed-off-by: Rob Herring <robh@xxxxxxxxxx> --- Rob Herring (5): of: unittest: Fix EXPECT for parse_phandle_with_args_map() test of: dynamic: Refactor action prints to not use "%pOF" inside devtree_lock of: dynamic: Fix race in getting old property when updating property of: dynamic: Move dead property list check into property add/update functions of: Refactor node and property manipulation function locking drivers/of/base.c | 86 ++++++++++++++++------------ drivers/of/dynamic.c | 153 +++++++++++--------------------------------------- drivers/of/unittest.c | 4 +- 3 files changed, 87 insertions(+), 156 deletions(-) --- base-commit: e251a4e28a27884e8bfb7fccbf53b24736f3ef87 change-id: 20230801-dt-changeset-fixes-b76b88fecc43 Best regards, -- Rob Herring <robh@xxxxxxxxxx>