Re: [PATCH v1 5/6] arm64: dts: allwinner: h616: Add BigTreeTech CB1 SoM & boards support

[Martin Botka <martin@xxxxxxxxxx>]

On 8/3/23 4:28 PM, Krzysztof Kozlowski wrote:
> On 03/08/2023 00:02, Martin Botka wrote:
> > From: Martin Botka <martin.botka@xxxxxxxxxxxxxx>
> >
> > CB1 is Compute Module style board that plugs into Rpi board style adapter or
> > Manta 3D printer boards (M4P/M8P).
> >
> > The SoM features:
> >    - H616 SoC
> >    - 1GiB of RAM
> >    - AXP313A PMIC
> >    - RTL8189FTV WiFi
>
> ...
>
> > +&mmc0 {
> > +	vmmc-supply = <&reg_dldo1>;
> > +	broken-cd;
> > +	bus-width = <4>;
> > +	status = "okay";
> > +};
> > +
> > +&mmc1 {
> > +	vmmc-supply = <&reg_vcc33_wifi>;
> > +	vqmmc-supply = <&reg_vcc_wifi_io>;
> > +	mmc-pwrseq = <&wifi_pwrseq>;
> > +	bus-width = <4>;
> > +	non-removable;
> > +	mmc-ddr-1_8v;
> > +	status = "okay";
> > +
> > +	rtl8189ftv: sdio_wifi@1 {
>
> No underxcores in node names. Generic node names, so probably "wifi".
Got it.
> > +		reg = <1>;
>
> Missing compatible?
No it is an explicitly defined SDIO device so we can add ethernet alias 
for it so we can for example set the MAC address of it via u-boot and etc :)

The actual driver for it is out of tree and from the current state of it 
looks like will be for a while.
Orange Pi Zero Plus based on H5 does this exact thing as well for the 
same purpose with the same wifi chip :)

Cheers,
Martin
> Best regards,
> Krzysztof